A simple, efficient, and ecofriendly procedure has been developed for the synthesis of quinoline and its derivatives in a one-pot reaction of aniline with crotonaldehyde or methyl vinyl ketone using phosphomolybdic acid as solid acid catalyst in miceller media. The catalyst was easily recycled and reused.